Rename fraud proof type for clarity #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested review from
vedhavyas,
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
vedhavyas
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
LGTM
While you cleaning up, would be nice to fix this TODO
https://github.com/autonomys/subspace/pull/2881/files#diff-339f9b12c12644ad8650eb8af4bf39396671f668b90f5000949a76057e9772edR1499
That was already fixed in a2d0c57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple changes I made as part of the rest of #3281.
Code contributor checklist: